opencd/VALIDATION.md

VALIDATION — OpenCD Production Build (t_70b74145)

Reviewer: Amy Amanda Allen amy@a-team.dev Date: 2026-05-25 Parent task: t_13557bde (B.A. Baracus — production opencd.css hardened) Commit under review: 415bb4f4029b9199b39e99582ccee24ac8c543b2 GPG: Signed with 1D05905DE3C03A27 (B.A. Baracus)

---

Verdict: CONCERNS

The production build is structurally sound and the bulk of quality criteria are met. However, three inline values in the component CSS violate the file's own stated principle ("Zero magic numbers — every value is a --cd-* custom property"). These are minor but need documenting.

---

1. GPG Signature — PASS

Check	Result	Evidence
Commit exists	✓	415bb4f4029b9199b39e99582ccee24ac8c543b2
GPG-signed	✓	Signature present in git log --show-signature
Correct key	✓	RSA 1D05905DE3C03A27 — B.A. Baracus ba@a-team.dev
Author match	✓	Author: B.A. Baracus <ba@a-team.dev>

Note: B.A.'s public key not in Amy's keyring (expected — cross-team validation). Signature field is present and well-formed.

---

2. Nous Auth — PASS

Check	Result	Evidence
.env.example has auth config	✓	NOUS_AGENT_KEY_ID=cmpkk7n6k000tkq0birz3zk5a with placeholder key
.env gitignored	✓	.gitignore line 2: .env
.gitignore committed	✓	Commit 415bb4f includes .gitignore
.env.example committed	✓	Commit 415bb4f includes .env.example

.env (the actual secrets file) is gitignored and read-protected — intentional and correct behavior. The example file provides the full schema.

---

3. Template Variable Fixes — PASS

Check	Result	Evidence
var(--font-system-ui) in jewel-case.html	FIXED ✓	Line 19: font-family: var(--font-sans)
var(--font-system-ui) in leaflet.html	FIXED ✓	Line 19: font-family: var(--font-sans)
var(--font-system-ui) in back-tray.html	FIXED ✓	Line 19: font-family: var(--font-sans)
Any remaining --font-system-ui in templates or CSS	NONE ✓	Only in RECON.md (historical reference, not active code)
--cd-font-neo-grotesque canonical throughout	CONSISTENT ✓	Defined line 53, referenced as --cd-font-label line 54, used in all templates

---

4. opencd.css — Zero Magic Numbers Review

File structure: 703 lines — custom properties / reset / jewel case / spine / leaflet / disc art / advisory badge / back tray / grid overlay / open/close states / responsive / print / grain texture.

4.1 Physical CD Dimensions — PASS

All dimensions documented with ISO 15727 reference and formula:

--cd-jewel-width:      calc(280px * var(--cd-scale));   /* 142 mm × 2 */
--cd-jewel-height:     calc(245px * var(--cd-scale));   /* 125 mm × 2 */
--cd-jewel-open-width: calc(560px * var(--cd-scale));   /* 284 mm × 2 */
--cd-disc-diameter:    calc(240px * var(--cd-scale));   /* 120 mm × 2 */
--cd-disc-hole:        calc(30px  * var(--cd-scale));   /* Ø15 mm × 2 */
--cd-leaflet-size:     calc(240px * var(--cd-scale));   /* 120 mm sq × 2 */
--cd-spine-width:      calc(14px  * var(--cd-scale));   /* ~7 mm × 2 */
--cd-tray-width:       calc(260px * var(--cd-scale));   /* ~130 mm × 2 */

4.2 Custom Property Surface — PASS

~60 --cd-* tokens defined across: dimensions, surface colors (oklch — not Open Props), typography, spacing, text colors, grid colors, advisory badge, shadows, borders, letter spacing, motion/easing, print dimensions, grain texture, responsive breakpoints, disc decoration ratios.

4.3 Magic Number Audit — CONCERNS

The file header states: "Zero magic numbers — every value is a --cd- custom property"*

Three values in component CSS violate this:

Line	Location	Value	Issue
247	.spine-label	font-weight: 600	Should be a --cd-* property (e.g. --cd-font-weight-semibold)
256	.spine-track	opacity: 0.8	Should be a --cd-* property (e.g. --cd-text-opacity-muted)
373	.disc-hole	z-index: 1	Should be a --cd-* property (e.g. --cd-z-stack-base)

Severity: Low. These are minor and don't cause functional issues. They contradict the file's own stated principle. Open Props provides --font-weight-6 (= 600) and --elevation-z-* for z-index, which could also serve here.

4.4 Grid Overlay — PASS

Five utility classes: .cd-grid (base), --fine, --coarse, --crosshatch, and content crosshatch. Uses --cd-grid-color / --cd-grid-color-alt from custom tokens (not Open Props directly, per Gate review Finding #2). All offset values are structural (not design magic numbers).

4.5 ASW Semantic Surface — PASS

Surface layers defined in oklch with custom values (not Open Props, per Gate review Finding #1):

• --cd-surface-1 through --cd-surface-4 — ASW-style oklch values
• --cd-surface-0 — via var(--gray-0) for lightest surface
• Semantic aliases: --cd-tray-bg, --cd-tray-bg-raised, --cd-tray-bg-sunken, --cd-spine-bg

4.6 Component Architecture — PASS

Component hierarchy clean: jewel case container → spine + inner → leaflet content + disc art + advisory badge → back tray. Open/closed state governed by both BEM modifier and data-jewel-state attribute. Container queries handle responsive layout. Print styles auto-switch to physical mm dimensions.

---

5. Additional Files — PASS

File	Status	Notes
templates/jewel-case.html	✓	Demo controls for open/close + scale. Inline JS functional
templates/leaflet.html	✓	4-page booklet with page-turn navigation. Functional
templates/back-tray.html	✓	Dual spines, tracklist, credits, grid toggle. Functional
.env.example	✓	Nous auth schema provided
.gitignore	✓	.env excluded, plus standard ignores
opencd.css	✓	See §4 above

---

Summary

PASS      12 — GPG signature, Nous auth, template fixes, dimensions, 
               surfaces, grid, components, responsive, print, grain, 
               .env.example, .gitignore
CONCERNS   1 — Three inline values violate zero-magic-numbers principle
FAIL       0

Recommendation: Accept the deliverable as production-ready. The three magic numbers are cosmetic inconsistencies with the stated principle, not functional defects. Consider addressing them in a follow-up commit for principle purity.