trentuna/candle-annotator
8
0
Fork 0
Code Issues Pull requests Releases Packages Activity Actions

code-review-fix task 9.8: replace any types with proper interfaces

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marko Djordjevic 2026-02-18 20:25:50 +01:00
parent 1b637dc45e
commit ba20d9e5ab
3 changed files with 25 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/CandleChart.tsx
View file

@ -1,7 +1,7 @@
'use client';
import { useEffect, useRef, useState, useImperativeHandle, forwardRef } from 'react';
import { createChart, IChartApi, ISeriesApi, CandlestickData, HistogramData, Time, SeriesMarker } from 'lightweight-charts';
import { createChart, IChartApi, ISeriesApi, CandlestickData, HistogramData, Time, SeriesMarker, MouseEventParams } from 'lightweight-charts';
import { useTheme } from 'next-themes';
import SpanAnnotationManager from './SpanAnnotationManager';
import { TrendLine } from '@/plugins/trend-line';
@ -589,7 +589,7 @@ const CandleChart = forwardRef<CandleChartHandle, CandleChartProps>(
return distance <= ENDPOINT_CLICK_TOLERANCE_PX;
};
const handleClick = async (param: any) => {
const handleClick = async (param: MouseEventParams) => {
if (!param.point) return;
const timeCoordinate = param.point.x;
@ -997,7 +997,7 @@ const CandleChart = forwardRef<CandleChartHandle, CandleChartProps>(
if (drawingState && !previewPrimitiveRef.current) return;
let isUpdating = false;
const handleCrosshairMove = (param: any) => {
const handleCrosshairMove = (param: MouseEventParams) => {
if (isUpdating) return;
if (!param.point) return;

22
src/components/SpanAnnotationManager.tsx
View file

@ -1,7 +1,7 @@
'use client';
import { useEffect, useState, useRef, useCallback } from 'react';
import { IChartApi, ISeriesApi, Time } from 'lightweight-charts';
import { IChartApi, ISeriesApi, Time, MouseEventParams } from 'lightweight-charts';
import { SpanRectanglePrimitive, SpanData } from './SpanRectanglePrimitive';
import SpanPopover from './SpanPopover';
import type { Candle, SpanAnnotation, SpanLabelType } from '@/types';
@ -176,11 +176,12 @@ export default function SpanAnnotationManager({
setEndCandle(null);
}
const handleClick = (param: any) => {
const handleClick = (param: MouseEventParams) => {
if (!param.point) return;
const point = param.point;
const time = chart.timeScale().coordinateToTime(param.point.x);
const price = series.coordinateToPrice(param.point.y);
const time = chart.timeScale().coordinateToTime(point.x);
const price = series.coordinateToPrice(point.y);
if (!time || !price) return;
// Handle span tool two-click interaction
@ -194,7 +195,7 @@ export default function SpanAnnotationManager({
// Check if clicking on existing span for selection
let clickedSpanId: number | null = null;
primitivesRef.current.forEach((primitive, spanId) => {
if (primitive.hitTest(param.point.x, param.point.y)) {
if (primitive.hitTest(point.x, point.y)) {
clickedSpanId = spanId;
}
});
@ -228,7 +229,7 @@ export default function SpanAnnotationManager({
// Delete span on click with delete tool
let clickedSpanId: number | null = null;
primitivesRef.current.forEach((primitive, spanId) => {
if (primitive.hitTest(param.point.x, param.point.y)) {
if (primitive.hitTest(point.x, point.y)) {
clickedSpanId = spanId;
}
});
@ -240,7 +241,7 @@ export default function SpanAnnotationManager({
// Click to select span when no tool is active
let clickedSpanId: number | null = null;
primitivesRef.current.forEach((primitive, spanId) => {
if (primitive.hitTest(param.point.x, param.point.y)) {
if (primitive.hitTest(point.x, point.y)) {
clickedSpanId = spanId;
}
});
@ -271,7 +272,7 @@ export default function SpanAnnotationManager({
return;
}
const handleMouseMove = (param: any) => {
const handleMouseMove = (param: MouseEventParams) => {
if (!param.point) return;
const time = chart.timeScale().coordinateToTime(param.point.x);
@ -542,12 +543,13 @@ export default function SpanAnnotationManager({
useEffect(() => {
if (!chart) return;
const handleDblClick = (param: any) => {
const handleDblClick = (param: MouseEventParams) => {
if (!param.point) return;
const point = param.point;
let clickedSpanId: number | null = null;
primitivesRef.current.forEach((primitive, spanId) => {
if (primitive.hitTest(param.point.x, param.point.y)) {
if (primitive.hitTest(point.x, point.y)) {
clickedSpanId = spanId;
}
});