feat: add file type validation to upload endpoint

- Validate filename ends with .csv (case-insensitive)
- Validate MIME type is text/* or application/csv or text/csv
- Return HTTP 400 with error message if validation fails
- Mark task 2.4 as complete
This commit is contained in:
Marko Djordjevic 2026-02-18 11:01:28 +01:00
parent 0e239dc3da
commit 94bc5768d1
2 changed files with 19 additions and 1 deletions

View file

@ -14,7 +14,7 @@
- [x] 2.1 `[haiku]` Validate `run_id` matches `/^[a-zA-Z0-9_-]+$/` in `src/app/api/training/runs/[run_id]/route.ts` before interpolation
- [x] 2.2 `[sonnet]` Validate `run_id` format and use `Path.resolve()` + directory containment check in `services/ml/app/main.py` (model load at line 1203, delete at line 1312)
- [x] 2.3 `[sonnet]` Add file size check (reject >10MB) and row count limit (500,000) to `src/app/api/upload/route.ts`
- [ ] 2.4 `[haiku]` Add file type validation (`.csv` extension, text MIME type) to `src/app/api/upload/route.ts`
- [x] 2.4 `[haiku]` Add file type validation (`.csv` extension, text MIME type) to `src/app/api/upload/route.ts`
- [ ] 2.5 `[haiku]` Fix CORS in `services/ml/app/main.py`: replace `allow_origins=["*"]` with `["http://localhost:3000"]` and support `CORS_ORIGINS` env var
## 3. Authentication

View file

@ -36,6 +36,24 @@ export async function POST(request: NextRequest): Promise<NextResponse> {
);
}
// Validate file type
const fileName = file.name.toLowerCase();
if (!fileName.endsWith('.csv')) {
return NextResponse.json(
{ error: 'Invalid file type. Only CSV files are accepted.' },
{ status: 400 }
);
}
const mimeType = file.type;
const isValidMimeType = mimeType.startsWith('text/') || mimeType === 'application/csv' || mimeType === 'text/csv';
if (!isValidMimeType) {
return NextResponse.json(
{ error: 'Invalid file type. Only CSV files are accepted.' },
{ status: 400 }
);
}
const MAX_FILE_SIZE = 10 * 1024 * 1024; // 10MB
if (file.size > MAX_FILE_SIZE) {
return NextResponse.json(