trentuna/candle-annotator
8
0
Fork 0
Code Issues Pull requests Releases Packages Activity Actions

Archive code-review-fix change and sync specs to main

Browse source 
- Synced 14 capability delta specs to main specs
- Created 6 new main specs: api-authentication, error-boundary, input-validation, security-headers, shared-types
- Updated 8 existing specs with security, validation, and performance requirements
- Archived change to openspec/changes/archive/2026-02-20-code-review-fix/

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marko Djordjevic 2026-02-20 08:54:59 +01:00
parent adb93a2d2e
commit 925e7284e3
32 changed files with 691 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

23
openspec/changes/code-review-fix/specs/error-boundary/spec.md
View file

@ -1,23 +0,0 @@
## ADDED Requirements
### Requirement: React Error Boundary component
The application SHALL include a React Error Boundary component that catches JavaScript errors in its child component tree and renders a fallback UI instead of crashing to a white screen. The fallback SHALL display: an error message, a "Reload" button that calls `window.location.reload()`, and a "Try Again" button that resets the error boundary state.
#### Scenario: Child component throws during render
- **WHEN** CandleChart or any child component throws an error during rendering
- **THEN** the Error Boundary catches the error and renders the fallback UI instead of a white screen
#### Scenario: Fallback UI interaction
- **WHEN** the user sees the error fallback and clicks "Try Again"
- **THEN** the Error Boundary resets its state and attempts to re-render the child component tree
#### Scenario: Error logging
- **WHEN** the Error Boundary catches an error
- **THEN** the error and component stack are logged via `console.error`
### Requirement: Error Boundary placement in layout
The root layout (`src/app/layout.tsx`) SHALL wrap `{children}` with the Error Boundary component so that any render error in any page is caught.
#### Scenario: Layout wraps children
- **WHEN** the application renders any page
- **THEN** the page content is wrapped inside an Error Boundary