feat: add Zod schema validation to patterns/detect route

- Import z from zod
- Add CandleSchema validating time, open, high, low, close (number), volume (optional number)
- Add PatternDetectRequestSchema validating candles array and patterns array of non-empty strings
- Use safeParse() and return HTTP 400 with error details on validation failure
- Forward only validated data to the inference service
- Mark task 4.5 as completed in tasks.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marko Djordjevic 2026-02-18 11:14:36 +01:00
parent 2e02d155af
commit 81e3554d82
2 changed files with 28 additions and 2 deletions

View file

@ -30,7 +30,7 @@
- [x] 4.2 `[sonnet]` Add Zod schema validation to `src/app/api/predict/batch/route.ts` (validate pair, timeframe, start_date, end_date) - [x] 4.2 `[sonnet]` Add Zod schema validation to `src/app/api/predict/batch/route.ts` (validate pair, timeframe, start_date, end_date)
- [x] 4.3 `[sonnet]` Add Zod schema validation to `src/app/api/model/load/route.ts` (validate run_id) - [x] 4.3 `[sonnet]` Add Zod schema validation to `src/app/api/model/load/route.ts` (validate run_id)
- [x] 4.4 `[sonnet]` Add Zod schema validation to `src/app/api/training/start/route.ts` (validate model_type) - [x] 4.4 `[sonnet]` Add Zod schema validation to `src/app/api/training/start/route.ts` (validate model_type)
- [ ] 4.5 `[sonnet]` Add Zod schema validation to `src/app/api/patterns/detect/route.ts` (validate candles, patterns array) - [x] 4.5 `[sonnet]` Add Zod schema validation to `src/app/api/patterns/detect/route.ts` (validate candles, patterns array)
- [ ] 4.6 `[sonnet]` Replace `error.message` with generic `"Internal server error"` in all catch blocks across 7+ route files: `health/route.ts`, `candles/route.ts`, `annotations/route.ts`, `annotations/[id]/route.ts`, `upload/route.ts`, `export/route.ts`, `span-annotations/export/route.ts` - [ ] 4.6 `[sonnet]` Replace `error.message` with generic `"Internal server error"` in all catch blocks across 7+ route files: `health/route.ts`, `candles/route.ts`, `annotations/route.ts`, `annotations/[id]/route.ts`, `upload/route.ts`, `export/route.ts`, `span-annotations/export/route.ts`
- [ ] 4.7 `[sonnet]` Require `chartId` for bulk delete in `src/app/api/annotations/route.ts` — reject `?all=true` without chartId with HTTP 400 - [ ] 4.7 `[sonnet]` Require `chartId` for bulk delete in `src/app/api/annotations/route.ts` — reject `?all=true` without chartId with HTTP 400
- [ ] 4.8 `[sonnet]` Wrap chart cascade delete in `db.transaction()` and add `spanAnnotations` deletion in `src/app/api/charts/[id]/route.ts` - [ ] 4.8 `[sonnet]` Wrap chart cascade delete in `db.transaction()` and add `spanAnnotations` deletion in `src/app/api/charts/[id]/route.ts`

View file

@ -1,9 +1,24 @@
import { NextRequest, NextResponse } from 'next/server'; import { NextRequest, NextResponse } from 'next/server';
import { z } from 'zod';
const INFERENCE_API_URL = process.env.INFERENCE_API_URL || 'http://localhost:8001'; const INFERENCE_API_URL = process.env.INFERENCE_API_URL || 'http://localhost:8001';
// Pattern detection may take longer on large datasets // Pattern detection may take longer on large datasets
const INFERENCE_API_TIMEOUT = parseInt(process.env.INFERENCE_API_TIMEOUT || '60000', 10); const INFERENCE_API_TIMEOUT = parseInt(process.env.INFERENCE_API_TIMEOUT || '60000', 10);
const CandleSchema = z.object({
time: z.number(),
open: z.number(),
high: z.number(),
low: z.number(),
close: z.number(),
volume: z.number().optional(),
});
const PatternDetectRequestSchema = z.object({
candles: z.array(CandleSchema),
patterns: z.array(z.string().min(1)),
});
export async function POST(request: NextRequest) { export async function POST(request: NextRequest) {
const controller = new AbortController(); const controller = new AbortController();
const timeoutId = setTimeout(() => controller.abort(), INFERENCE_API_TIMEOUT); const timeoutId = setTimeout(() => controller.abort(), INFERENCE_API_TIMEOUT);
@ -11,10 +26,21 @@ export async function POST(request: NextRequest) {
try { try {
const body = await request.json(); const body = await request.json();
const result = PatternDetectRequestSchema.safeParse(body);
if (!result.success) {
clearTimeout(timeoutId);
return NextResponse.json(
{ error: 'Invalid request', details: result.error.flatten() },
{ status: 400 }
);
}
const validatedBody = result.data;
const response = await fetch(`${INFERENCE_API_URL}/patterns/detect`, { const response = await fetch(`${INFERENCE_API_URL}/patterns/detect`, {
method: 'POST', method: 'POST',
headers: { 'Content-Type': 'application/json', 'X-API-Key': process.env.API_KEY || '' }, headers: { 'Content-Type': 'application/json', 'X-API-Key': process.env.API_KEY || '' },
body: JSON.stringify(body), body: JSON.stringify(validatedBody),
signal: controller.signal, signal: controller.signal,
}); });
clearTimeout(timeoutId); clearTimeout(timeoutId);