From 6d0d67e39b52d42838ebec43726cc0cf45cde64a Mon Sep 17 00:00:00 2001
From: Marko Djordjevic <marko.homoludens@gmail.com>
Date: Sun, 15 Feb 2026 21:43:14 +0100
Subject: [PATCH] fix(ml): make pair and timeframe optional in PredictRequest

- Change pair and timeframe fields from required to optional
- Frontend only sends candles array, not pair/timeframe metadata
- These fields are only used for logging, not prediction logic
- Update logging to handle None values with 'unknown' fallback
- Fixes 422 validation error on /predict endpoint
---
 .../ml/app/__pycache__/main.cpython-313.pyc   | Bin 29892 -> 29981 bytes
 services/ml/app/main.py                       |   6 +++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/services/ml/app/__pycache__/main.cpython-313.pyc b/services/ml/app/__pycache__/main.cpython-313.pyc
index 4d97bbaf8c484b41cd98959e097c8270eb33d644..227dfb46afa901f0fc45f86728525d408c652892 100644
GIT binary patch
delta 702
zcmZvY-%C?r7{}lD{Me84YyQ}rPUoi1=9Ektv!+vLO5m@vGvAI-4NWN{!kd8_f#^-B
z1ra_M77=KFK{bS^o4_EAv@;CmDyS~=Dk!3xsQ09J)pPN@-{<>z`10_+{E8p!Vfni(
z3y9X*v85}q$1)@0DOh!tK}amnc<QI@#1b@Lz8VphSP36x(n89bvK>&{A+-~Mh(wCA
zX)z_G<O437oG5AKG7B?e8&=`Dn8b}BNiinmfIr0^QK1{@4zqD^RqBrPQaO+ETw~tj
zTj7l3iL6JP>t3k46J9*J!)bY6VC9T)LeKh!=6V*c-DMYNcDSL;N9kvbxoLyWP6EN+
zFQsj`j^>zkkwM6hh*d$vrX$e2&XWH^I~?h2zyb{REn^Y(`p#kr-d_lVcfb$J{llzG
z6!_Kun|0`RxIN|uhx!l~z!Q})g*<#pRKc48Cr64R7(T1DO!1)yyNSAe=Gtf067zG2
z8*EyQTzbCz-<7oK3TT>Jc0};LLl5>qN{irfSki*H0-kAJ?1f!z0$0N6<SoUg7bz&r
z5I?DkGJaU?t;aqP2E(`-+6O=I=^HdBQ$`F1Z^52E-;oQnJ?b%P+MkZTu;${)Y&@BZ
z4;%Wh(J^9-jJ_MYWQ<Sb#wWAmlRINm#^|&$J^Kxz!cOJ~Li{Nvb8o1SopmNzyzW-i
zCbV8#rn<QG_O2E>ygJ#edbo{7E7cnjm+Ip-g(9jqE9%vN?X{(=lnz^!PPL(AtJz}q
vnCWagG0od{m7BUrNFsK-C7KAcZ^JUx25Qw>S)-MwI*VAkc|8+4ci;0DM31`a

delta 611
zcmYk1%TE(g6vlh!&a~6c!?rNA)6!x^Ek&%6v1kPZr35KBGxP?cQZ&X`B8e>OPE7<|
zh;dQPS*S54`X7`uapT4W6Ivs52qvboF>&Q1G0~`7@5sipIQgCLd^wM&U(oB%Nct&B
z9tREO&4bJ0vcw2z4!lAF4ydkvZkK~#;v!s{DZ2BnJWu#IwdS{VH}Mc5jf<YVkQX^y
z=ZR?diByzkWw<N!qa>^f6QGKHSWn0>sDzv{H53QnhM3uZg5n)VgH1NP%KeL0JhR~)
zUdSx9Z?eM;CG<$My0RO}*uv=2)lGJ+@=N^PhYFQ%qbbD74&s96=YkU9r^9s0znFxD
zumb02c)RU}(%3`B!$G+<00ZO4kpPS1%WjcKX=a```r*QO6waJ#AQ?3MCE5Ysb;5W#
z_-OQCUkX9Q*aM|*4n7$gYJx4J7d{wqktp_`q$TZ~_rlj~n;Q6Uy_`bZhtTywSTqAj
zg~w(Jg`jT6Q5gQ15!4FG#1#~Q+Y|SM=%inEXbfp1JHb~_!OAwHD2(JZ6oc!zt;#g9
z80H0r(%e2cJvH6&>{!`XKKx$GY-ky)d-zrEEv}B#jheA}GH;E{STmO_Z{Zy~Tlq2N
z!#5f8AX?#MJ?dC#QgzI(bPXM)#p>Q3ooB19F3Qz*MVHv>5kKXcr&IUywL?QeTC9o9
zy4td~+iB-cTUloiowts|Hb*^X60dipjTo-SB+B(<ubIGBf}?CDF?C+6+&cRt^cQis
BrQ!ep

diff --git a/services/ml/app/main.py b/services/ml/app/main.py
index 7524d77..44cfd7d 100644
--- a/services/ml/app/main.py
+++ b/services/ml/app/main.py
@@ -71,8 +71,8 @@ class CandleData(BaseModel):
 
 class PredictRequest(BaseModel):
     """Request model for /predict endpoint."""
-    pair: str = Field(..., description="Trading pair (e.g., EURUSD)")
-    timeframe: str = Field(..., description="Timeframe (e.g., 1H, 4H, 1D)")
+    pair: Optional[str] = Field(None, description="Trading pair (e.g., EURUSD)")
+    timeframe: Optional[str] = Field(None, description="Timeframe (e.g., 1H, 4H, 1D)")
     candles: List[CandleData] = Field(..., min_length=1, description="Array of candle data")
 
 
@@ -518,7 +518,7 @@ async def predict(request: PredictRequest):
             detail="Pipeline configuration not loaded"
         )
     
-    logger.info(f"Predict request: {request.pair} {request.timeframe}, {len(request.candles)} candles")
+    logger.info(f"Predict request: {request.pair or 'unknown'} {request.timeframe or 'unknown'}, {len(request.candles)} candles")
     
     try:
         # Convert candles to list of dicts