diff --git a/openspec/changes/code-review-fix/tasks.md b/openspec/changes/code-review-fix/tasks.md index c4b26e0..bb68594 100644 --- a/openspec/changes/code-review-fix/tasks.md +++ b/openspec/changes/code-review-fix/tasks.md @@ -27,7 +27,7 @@ ## 4. API Route Hardening (Next.js) - [x] 4.1 `[sonnet]` Add Zod schema validation to `src/app/api/predict/route.ts` (validate pair, timeframe, candles array) -- [ ] 4.2 `[sonnet]` Add Zod schema validation to `src/app/api/predict/batch/route.ts` (validate pair, timeframe, start_date, end_date) +- [x] 4.2 `[sonnet]` Add Zod schema validation to `src/app/api/predict/batch/route.ts` (validate pair, timeframe, start_date, end_date) - [ ] 4.3 `[sonnet]` Add Zod schema validation to `src/app/api/model/load/route.ts` (validate run_id) - [ ] 4.4 `[sonnet]` Add Zod schema validation to `src/app/api/training/start/route.ts` (validate model_type) - [ ] 4.5 `[sonnet]` Add Zod schema validation to `src/app/api/patterns/detect/route.ts` (validate candles, patterns array) diff --git a/src/app/api/predict/batch/route.ts b/src/app/api/predict/batch/route.ts index cf0ec82..556b9b9 100644 --- a/src/app/api/predict/batch/route.ts +++ b/src/app/api/predict/batch/route.ts @@ -1,12 +1,30 @@ import { NextRequest, NextResponse } from 'next/server'; +import { z } from 'zod'; const INFERENCE_API_URL = process.env.INFERENCE_API_URL || 'http://localhost:8001'; const INFERENCE_BATCH_TIMEOUT = parseInt(process.env.INFERENCE_BATCH_TIMEOUT || '120000', 10); +const BatchPredictRequestSchema = z.object({ + pair: z.string().min(1), + timeframe: z.string().min(1), + start_date: z.string().min(1), + end_date: z.string().min(1), +}); + export async function POST(request: NextRequest) { try { const body = await request.json(); + const result = BatchPredictRequestSchema.safeParse(body); + if (!result.success) { + return NextResponse.json( + { error: 'Invalid request', details: result.error.flatten() }, + { status: 400 } + ); + } + + const validatedBody = result.data; + // Forward request to Python inference service const controller = new AbortController(); const timeoutId = setTimeout(() => controller.abort(), INFERENCE_BATCH_TIMEOUT); @@ -18,7 +36,7 @@ export async function POST(request: NextRequest) { 'Content-Type': 'application/json', 'X-API-Key': process.env.API_KEY || '', }, - body: JSON.stringify(body), + body: JSON.stringify(validatedBody), signal: controller.signal, });