From 55ee9c936ac6d8ec1023ce17c1a76418793a7a38 Mon Sep 17 00:00:00 2001 From: Marko Djordjevic Date: Wed, 18 Feb 2026 10:56:23 +0100 Subject: [PATCH] fix: replace real credentials in .env.example with placeholders - Replace ml_password with change_me_to_a_strong_password placeholder - Replace ml_user with your_db_user placeholder - Mark task 1.3 as completed in tasks.md Co-Authored-By: Claude Sonnet 4.6 --- .env.example | 2 +- openspec/changes/code-review-fix/tasks.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.env.example b/.env.example index d8cef2c..0a7db31 100644 --- a/.env.example +++ b/.env.example @@ -1,6 +1,6 @@ NODE_ENV=production PORT=3000 -DATABASE_URL=postgresql://ml_user:ml_password@postgres:5432/candle_annotator +DATABASE_URL=postgresql://your_db_user:change_me_to_a_strong_password@postgres:5432/candle_annotator # ML Inference Service Configuration INFERENCE_API_URL=http://localhost:8001 diff --git a/openspec/changes/code-review-fix/tasks.md b/openspec/changes/code-review-fix/tasks.md index 1cb07ef..f6a5df0 100644 --- a/openspec/changes/code-review-fix/tasks.md +++ b/openspec/changes/code-review-fix/tasks.md @@ -2,7 +2,7 @@ - [x] 1.1 `[haiku]` Add `.env` to `.gitignore` and run `git rm --cached .env` to untrack it - [x] 1.2 `[haiku]` Add `models/` and `*.pkl` to `.gitignore` -- [ ] 1.3 `[haiku]` Replace real credentials in `.env.example` with placeholders (`POSTGRES_PASSWORD=change_me_to_a_strong_password`) +- [x] 1.3 `[haiku]` Replace real credentials in `.env.example` with placeholders (`POSTGRES_PASSWORD=change_me_to_a_strong_password`) - [ ] 1.4 `[haiku]` Remove SQL comment with credentials from `services/ml/app/db.py` and add fail-fast check for missing `DATABASE_URL` - [ ] 1.5 `[sonnet]` Update `docker-compose.yml` to use `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, `${POSTGRES_DB}` env var interpolation in all DATABASE_URL values - [ ] 1.6 `[haiku]` Bind PostgreSQL port to `127.0.0.1:5432:5432` in `docker-compose.yml`